[PATCH 14/25] OMAP4: PM: Add CPUX OFF mode support

Santosh santosh.shilimkar at ti.com
Sat Sep 10 01:51:24 EDT 2011


On Saturday 10 September 2011 10:24 AM, Shawn Guo wrote:
> On Sat, Sep 10, 2011 at 09:08:16AM +0530, Shilimkar, Santosh wrote:
>> IOn Sat, Sep 10, 2011 at 5:04 AM, Shawn Guo<shawn.guo at freescale.com>  wrote:
> [...]
>>> Also, IMO, lable "l2x_clean_inv" should be put after the "bne do_WFI".
>>> Otherwise, my original statement (it seems l2x_clean_inv will be
>>> called for case "2") stands correct :)
>>>
>> It's just a label. All L2 related code and checks for the valid state is
>> kept under that by purpose.
>>
> So for some case, you enter l2x_clean_inv but do not actually clean
> and invalidate L2.  I do not see this label being used anywhere, so
> you may want to remove it to save the confusion to stupid people like
> me.  Just my opinion.
>
Will remove the label :)

Regards
Santosh



More information about the linux-arm-kernel mailing list