[PATCH 3/4] mach-integrator: modernize clock event registration

Linus Walleij linus.walleij at linaro.org
Thu Sep 8 05:23:57 EDT 2011


On Thu, Sep 8, 2011 at 10:55 AM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
>> Acked-by: Thomas Gleixner <tglx at linutronix.de>

> My understanding is that periodic timers are not setup by the generic
> clock event code, and so we do need to keep the 'timer_reload' stuff
> around.

Aha. Yes maybe I've not tested that mode well enough, I'll
have a closer look.

An alteranative is to retire the periodic mode and only
support oneshot, like the plat-nomadik/timer.c currently
does. My impression is that oneshot will always work fine,
and doing this leaves all details up to the timekeeping
core so we don't need to deal with it, but I may be wrong.
Ideas?

> Note that patch 2 deletes the register write for this too,
> so you actually have one logical change split across patch 2 and 3.

Yes, no good. I'll fix.

Yours,
Linus Walleij



More information about the linux-arm-kernel mailing list