[PATCH 16/18] dmaengine/amba-pl08x: Add support for sg len greater than one for slave transfers
Viresh Kumar
viresh.kumar at st.com
Wed Sep 7 23:50:12 EDT 2011
On 9/8/2011 4:31 AM, Linus Walleij wrote:
> I think the patch brings valuable functionality we don't want to loose when
> there is a solution. Basically the dmaengine has a contract to handle
> sglists of any lengths and it's a pity that we don't, and I suspect Viresh
> cannot use the driver for MMC unless something like this is added, so
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>
Thanks Again.
> BUT I think it is possible to rewrite it a bit later so as to get a better
> handling of this. Isn't Russells initial remark that the LLI:s can simply just
> take in the entire sglist at once true?
If i am getting this clearly, the concern is "why to queue separate transfers for
individual sg's? Better would be to prepare the complete list at once and
start the transfer, so that DMA stops only after finishing all sg's
passed from user." Is this what you are pointing at?
If yes, then the same is done in this patch too. An array for llis is allocated at
the start, then for each sg i prepare lli list from this array. Last lli from one sg
is followed by first lli from next sg. And so i get a continuous chain of llis.
--
viresh
More information about the linux-arm-kernel
mailing list