[PATCH 3/6] arm/imx6q: add core drivers clock, gpc, mmdc and src
shawn.guo at freescale.com
Wed Sep 7 02:05:03 EDT 2011
On Tue, Sep 06, 2011 at 09:14:29PM +0200, Arnd Bergmann wrote:
> On Tuesday 06 September 2011 17:58:37 Shawn Guo wrote:
> > It adds a number of core drivers support for imx6q, including clock,
> > General Power Controller (gpc), Multi Mode DDR Controller(mmdc) and
> > System Reset Controller (src).
> > Signed-off-by: Ranjani Vaidyanathan <ra5478 at freescale.com>
> > Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> > ---
> > arch/arm/mach-imx/Kconfig | 13 +
> > arch/arm/mach-imx/Makefile | 4 +
> > arch/arm/mach-imx/clock-imx6q.c | 1990 +++++++++++++++++++++++++++++++++++++++
> > arch/arm/mach-imx/gpc.c | 110 +++
> > arch/arm/mach-imx/mmdc.c | 71 ++
> > arch/arm/mach-imx/src.c | 52 +
> > 6 files changed, 2240 insertions(+), 0 deletions(-)
> This is unfortunately still a major problem.
It's so sad to still get this comment. Back to Linaro Connect on
Cambridge, I believe I asked for your opinion on new SoC clock support
without waiting for the clock framework. You said you do not have a
strong position on this and would defer to others' judgement. Then
I talked to Russell and Grant respectively, and they both agree that
we should not be blocked by the clock framework. That's why I decided
to start upstreaming imx6q.
> I realize that we don't
> yet have a good framework to do this with significantly less code,
> but adding a platform that is mostly consisting of stupid additions
> of clock descriptions that really should be in the device tree does
> not scale much longer.
I definitely agree this does not scale for long term. And I would
immediately migrate it to clock framework once it gets ready and put
the description into device tree when clock binding is ready. Before
we get there, we need a way out. It's unreasonable for us to hold
the new soc support for an unspecified time. It's been 20 months since
we saw the common clock patches from Jeremy, and we do not know yet
how many months we still have to wait. Grant worked out the auxdata to
remove the device tree dependency on clock framework. I think we
should not get new soc support blocked by clock framework either.
> We decided to let this still get in for prima2,
> which was also ugly in this regard but much simpler than imx6.
It's unfair to me that you reject imx6q clock code just because it's
an implementation for a hardware complexer than prima2.
> My feeling is that this time, we should wait for the common clock
> framework to get in and simplify this. I believe Thomas is now planning
> to do this, but I haven't followed what the current state is.
Sadly, if this is the position of entire arm-soc maintainer group,
I think I have made a wrong decision to start upstreaming imx6q now.
> The other three drivers in this patch are basically ok, so you can
> definitely post them as a separate patch and perhaps get minor comments
> for those, similar to what I commented on the other patches.
> For the clock-imx6q.c file, what I first want to hear from someone
> is how this is supposed to look like in the long run with device tree
> integration, and how far away from that we are.
> Can you comment on how far we get without the clock driver with imx6?
> Is is basically useless, or is there a way we can merge the remaining
> imx6 code and other drivers but postpone the large clock driver?
Unfortunately, clock is pretty fundamental for imx6q support. Without
clock support, imx6q platform is useless. We have a real example here.
Back to Dec. 2010, Sascha refused to take clock patch when Freescale
was submitting imx50 platform support, because he thought the clock
framework will get merged pretty soon. But we end up with the facts
that clock framework is still up in the air and imx50 platform support
on mainline is totally useless.
I have been tried very hard to reduce the LOC of clock-imx6q.c. It's
a 5K LOC file in the Freescale internal tree. Now it's 2K LOC. I know
it's still large enough for you to dislike it. But this is the clock
that the hardware has. I'm afraid we can not do much to reduce the LOC
significantly, unless we only implement the small portion other than
the full clock tree, which is what I really hate to do.
More information about the linux-arm-kernel