[PATCH] mach-integrator: fix VGA base regression

Rob Herring robherring2 at gmail.com
Tue Sep 6 09:31:59 EDT 2011

On 09/06/2011 12:25 AM, Linus Walleij wrote:
> 2011/9/5 Rob Herring <robherring2 at gmail.com>:
>>>> Should the VGA memory really be accessed before PCI host is initialized?
>>> I don' know, I don't know one bit about how PCI works and should
>>> work, you tell me :-)
>> I guess it's normal (from init/main.c):
> Ah. I've even seen that comment in main.c.
> SHall I go over the other changes in the same and check for
> potential problems?

Integrator and footbridge are the only platforms that would ever
actually work with VGA console because the others are all returning a
physical address rather than a virtual address. kirkwood, dove, mv78xx0,
and orion5x are all wrong. I'm not sure on shark. Seems to be a virtual
address, but it's not mapped.

So perhaps the correct fix is just to remove the initialization of
vga_base on all these platforms.


More information about the linux-arm-kernel mailing list