[PATCH] arm: ixp4xx, u300: Select ARCH_REQUIRE_GPIOLIB, not GENERIC_GPIO

Ben Hutchings ben at decadent.org.uk
Mon Sep 5 12:22:26 EDT 2011


On Mon, Sep 05, 2011 at 02:41:30PM +0200, Linus Walleij wrote:
> On Mon, Sep 5, 2011 at 5:12 AM, Ben Hutchings <ben at decadent.org.uk> wrote:
> 
> > @@ -830,7 +830,7 @@ config ARCH_U300
> >        select GENERIC_CLOCKEVENTS
> >        select CLKDEV_LOOKUP
> >        select HAVE_MACH_CLKDEV
> > -       select GENERIC_GPIO
> > +       select ARCH_REQUIRE_GPIOLIB
> >        help
> >          Support for ST-Ericsson U300 series mobile platforms.
> 
> Please don't do that, it really is no gpiolib implementation.
> 
> In the archives you can find patches I already submitted switching
> the U300 GPIO over to use gpiolib.
[...]
 
OK.  But it doesn't seem to work without gpiolib either:

 CC [M]  drivers/input/touchscreen/ads7846.o                                                                                                                                                                                                                                                                             
drivers/input/touchscreen/ads7846.c: In function 'ads7846_setup_pendown':                                                                                                                              
drivers/input/touchscreen/ads7846.c:970:3: error: implicit declaration of function 'gpio_request_one' 

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus



More information about the linux-arm-kernel mailing list