[PATCH 1/4 v4] drivers: create a pin control subsystem

Linus Walleij linus.walleij at linaro.org
Fri Sep 2 03:57:28 EDT 2011


On Fri, Sep 2, 2011 at 9:02 AM, Stijn Devriendt <highguy at gmail.com> wrote:
> On Fri, Aug 19, 2011 at 11:53 AM, Linus Walleij
> <linus.walleij at stericsson.com> wrote:

>> +       if (desc->mux_requested) {
>> +               pr_err("pin already requested\n");
>> +               goto out;
>> +       }
>
> Isn't locking missing here?

You're right, I have now introduced a spinlock to the pin descriptor
and take that before reading or writing descriptor fields like this.

Thanks!
Linus Walleij



More information about the linux-arm-kernel mailing list