[RFC 6/8] of: add clock providers

Grant Likely grant.likely at secretlab.ca
Wed Nov 30 14:38:19 EST 2011


On Mon, Nov 21, 2011 at 8:37 AM, Shawn Guo <shawn.guo at freescale.com> wrote:
> On Tue, Nov 08, 2011 at 06:19:41PM -0700, Grant Likely wrote:
>> +struct clk *of_clk_get_by_name(struct device_node *np, const char *name)
>> +{
>> +     int index = 0;
>> +
>> +     if (name)
>> +             index = of_property_match_string(np, "clock-input-names", name);
>
> If it fails to match name, we may want to force 'index' back to 0.

Actually, if it fails to match, the function should fail.  Fixed.
Fixed all the editorial comments too.  Thanks.

>
> Also according to binding document above,
> s/clock-input-names/clock-input-name?  Hope you do not want to
> change binding document to get them aligned.  I have written code
> per binding document :)

I've changed to match the binding documentation.

Thanks for the review,
g.



More information about the linux-arm-kernel mailing list