[V3 2/6] RTC: sa1100: remove redundant code of setting alarm

Haojian Zhuang haojian.zhuang at gmail.com
Wed Nov 30 09:50:24 EST 2011


On Wed, Nov 30, 2011 at 9:50 PM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj at jcrosoft.com> wrote:
> On 14:30 Wed 30 Nov     , Jett.Zhou wrote:
>> In rtc generic interface of setting alarm, it will check the alarm time
>> value valid or not, so rtc_periodic_alarm is redundant, remove it.
>>
>> Signed-off-by: Jett.Zhou <jtzhou at marvell.com>
>> Acked-by: Haojian Zhuang <haojian.zhuang at gmail.com>
>> ---
>>  drivers/rtc/rtc-sa1100.c |   53 ++++++++++-----------------------------------
>>  1 files changed, 12 insertions(+), 41 deletions(-)
>>
>> diff --git a/drivers/rtc/rtc-sa1100.c b/drivers/rtc/rtc-sa1100.c
>> index 6f22c1f..d268cf1 100644
>> --- a/drivers/rtc/rtc-sa1100.c
>> +++ b/drivers/rtc/rtc-sa1100.c
>> @@ -45,16 +45,6 @@ static const unsigned long RTC_FREQ = 1024;
>>  static struct rtc_time rtc_alarm;
>>  static DEFINE_SPINLOCK(sa1100_rtc_lock);
>>
>> -static inline int rtc_periodic_alarm(struct rtc_time *tm)
>> -{
>> -     return  (tm->tm_year == -1) ||
>> -             ((unsigned)tm->tm_mon >= 12) ||
>> -             ((unsigned)(tm->tm_mday - 1) >= 31) ||
>> -             ((unsigned)tm->tm_hour > 23) ||
>> -             ((unsigned)tm->tm_min > 59) ||
>> -             ((unsigned)tm->tm_sec > 59);
>> -}
>> -
>>  /*
>>   * Calculate the next alarm time given the requested alarm time mask
>>   * and the current time.
>> @@ -82,27 +72,6 @@ static void rtc_next_alarm_time(struct rtc_time *next, struct rtc_time *now,
>>       }
>>  }
> please use read/write relaxed too
>
> Best Regards,
> J.

This will be replaced with read/write in the third patch.



More information about the linux-arm-kernel mailing list