[PATCH] USB: ehci-mxc: get rid of the uses of cpu_is_mx()

s.hauer at pengutronix.de s.hauer at pengutronix.de
Tue Nov 29 03:21:39 EST 2011

On Tue, Nov 29, 2011 at 08:02:53AM +0000, Chen Peter-B29397 wrote:
> > 
> > In the driver you would then do a clk_get() for those three clocks
> > independent of the platform.
> > 
> The reason why I add this patch is not for clk things, it is for:
> 1. Coming device driver
> 2. Handle things difference between SoC's. not only clk, others
> like low power, wakeup, hsic, or other will comes in future.

The ehci is a standardized core. Please be *very* careful with what you
add to this driver. As said in my other mail, the real differences are
in the phys and the phy handling code should not be in the ehci-mxc
driver at all.
Rather than adding random phy code to the driver you should write phy
drivers. If you still think that there is code missing in this driver
please explain further.


Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

More information about the linux-arm-kernel mailing list