[PATCH v2 1/4] ARM: vexpress: Get rid of MMIO_P2V

[Dave Martin]

On Mon, Nov 28, 2011 at 10:44:16AM +0000, Russell King - ARM Linux wrote:
> On Fri, Nov 25, 2011 at 04:15:00PM +0000, Dave Martin wrote:
> > diff --git a/arch/arm/plat-versatile/headsmp.S b/arch/arm/plat-versatile/headsmp.S
> > index d397a1f..0be2efc 100644
> > --- a/arch/arm/plat-versatile/headsmp.S
> > +++ b/arch/arm/plat-versatile/headsmp.S
> > @@ -28,6 +28,7 @@ ENTRY(versatile_secondary_startup)
> >  pen:	ldr	r7, [r6]
> >  	cmp	r7, r0
> >  	bne	pen
> > +ENDPROC(versatile_secondary_startup)
> 
> This is wrong.  You're telling the assembler that this function ends here.
> It doesn't, it continues on.  Put the ENDPROC at the end of the function.

Dunno what I was thinking of there -- agreed, the ENDPROC() should move
to the end of the file.

(I'm assuming that literals should be included in the size of the
relevant function symbol here -- that's the convention the compiler
follows.)

Cheers
---Dave