[PATCH] i2c-mxs: fix compile warning in mxs_i2c_xfer()
Uwe Kleine-König
u.kleine-koenig at pengutronix.de
Thu Nov 24 03:29:03 EST 2011
Hello Shawn,
On Thu, Nov 24, 2011 at 03:52:20PM +0800, Shawn Guo wrote:
> CC drivers/i2c/busses/i2c-mxs.o
> drivers/i2c/busses/i2c-mxs.c: In function ‘mxs_i2c_xfer’:
> drivers/i2c/busses/i2c-mxs.c:196:6: warning: ‘data’ may be used uninitialized in this function
>
> Signed-off-by: Shawn Guo <shawn.guo at linaro.org>
> ---
> drivers/i2c/busses/i2c-mxs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mxs.c b/drivers/i2c/busses/i2c-mxs.c
> index 7e78f7c..00f098f 100644
> --- a/drivers/i2c/busses/i2c-mxs.c
> +++ b/drivers/i2c/busses/i2c-mxs.c
> @@ -193,7 +193,7 @@ static int mxs_i2c_wait_for_data(struct mxs_i2c_dev *i2c)
>
> static int mxs_i2c_finish_read(struct mxs_i2c_dev *i2c, u8 *buf, int len)
> {
> - u32 data;
> + u32 data = 0;
> int i;
>
> for (i = 0; i < len; i++) {
Looks like a stupid compiler. Then better use
u32 uninitialized_var(data);
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
More information about the linux-arm-kernel
mailing list