[PATCH] IMX/SDMA : save the real count for one DMA transaction.

Huang Shijie b32955 at freescale.com
Wed Nov 23 06:29:20 EST 2011


> On Wed, Nov 23, 2011 at 07:13:23PM +0800, Huang Shijie wrote:
>>>>>> +	/* save the real count we received or transmitted. */
>>>>>> +	chan->private = (void *)count;
>>>>> And if someone later needs another variable which is private?
>>>>>
>>>> I ever wanted to add an new parameter `void *` to dma_aync_tx_callback,
>>>> but it seemed i have
>>>> to change a lot of files.
>>>>
>>>> Do you have any better suggestion?
>>> Use a private struct and put count in there.
>>>
>> Where to put the private struct? in the imx-sdma.c ?
>> If i put it there, how can i get it in the UART driver with the current
>> DMA API?
> So, in the UART driver you assume that void* is an int? Or how do you
> currently use count?
>
In the UART driver, I use the following lines:
-------------------------------------------------------
+ struct dma_chan *chan = sport->dma_chan_rx;
+ unsigned int count = (unsigned int)chan->private;
-------------------------------------------------------

Best Regards
Huang Shijie






More information about the linux-arm-kernel mailing list