[PATCH v5 3/4] drivers/i2c/busses/i2c-at91.c: add new driver
Voss, Nikolaus
N.Voss at weinmann.de
Wed Nov 23 05:28:47 EST 2011
Hi,
Carsten Behling wrote on 2011-11-23:
>> this case is already catched in at91_do_twi_transfer():
>
> Sorry, I did not found this code in your patch.
> (http://www.mail-archive.com/linux-i2c@vger.kernel.org/msg06556.html):
>
>> + if (is_read) {
>> + if (!dev->buf_len)
yes, this won't work for buf_len == 1. It is corrected in
https://lkml.org/lkml/2011/11/18/223 which I held back for some time
as it should have been just a feature extension. I was not aware it
also fixed the buf_len = 1 bug. Sorry for that...
(Explanation: in the first implementation I immediately decremented
buf_len, so buf_len == 1 could not occur. Later I removed that but
did not fully fold it into the base patch.)
Thanks,
Niko
More information about the linux-arm-kernel
mailing list