[PATCH 3/4] ARM: extract out code patch function from kprobes

Rabin Vincent rabin at rab.in
Tue Nov 22 13:03:23 EST 2011


On Tue, Nov 22, 2011 at 14:18, Tixy <tixy at yxit.co.uk> wrote:
> On Mon, 2011-11-21 at 20:43 +0530, Rabin Vincent wrote:
>> Extract out the code patching code from kprobes so that it can be used
>> from the jump label code.  Additionally, the separated code:
>>
>>  - Uses the IS_ENABLED() macros instead of the #ifdefs for THUMB2
>>    support
>>
>>  - Unifies the two separate functions in kprobes, providing one function
>>    that uses stop_machine() internally, and one that can be called from
>>    stop_machine() directly
>>
>>  - Patches the text on all CPUs only on processors requiring software
>>    broadcasting of cache operations
>>
>> Cc: Jon Medhurst <tixy at yxit.co.uk>
>> Signed-off-by: Rabin Vincent <rabin at rab.in>
>> ---
>
> Looks good. I've a couple of minor inline comments below.

Thank you for the review.  I'll address all your comments in v2.



More information about the linux-arm-kernel mailing list