[PATCH] arm/imx: use Kconfig choice for low-level debug UART selection
Russell King - ARM Linux
linux at arm.linux.org.uk
Tue Nov 22 10:48:38 EST 2011
On Tue, Nov 22, 2011 at 02:30:40PM +0100, Uwe Kleine-König wrote:
> On Tue, Nov 22, 2011 at 01:20:55PM +0000, Will Deacon wrote:
> > On Tue, Nov 22, 2011 at 01:02:33PM +0000, Uwe Kleine-König wrote:
> > > On Tue, Nov 22, 2011 at 11:50:17AM +0000, Will Deacon wrote:
> > > > In the end I'd like to remove DEBUG_LL_UART_NONE. It's only there to service
> > > > the platforms which have not yet added an entry to the choice.
> > > Why not remove it already now? If I remove it together with the entry
> > > for my machine and modify mach/debug-macro.S to do the right thing
> > > for my machine even without DEBUG_IMX25_UART, my build just works.
> >
> > I'm fairly sure this will break the build for everybody who doesn't have an
> > entry in Kconfig.debug choice if they try and select DEBUG_LL.
> Ah, I see the problem. It's more subtile than just failure to build: it
> autoselects DEBUG_ICEDCC then.
Which results in a kernel which builds fine, but when they attempt to
boot it appears to lock fairly solidly. So we had to add this option
to allow the possibility for unconverted platforms to continue working.
At this point, I think the right answer is to remove the option in
linux-next, and tell anyone who complains that they need to convert
their platform properly. (We're going to need them converted in this
way anyway for the single zImage project.)
More information about the linux-arm-kernel
mailing list