[PATCH] ARM: mx5: Fix checkpatch warnings in cpu-imx5.c

Joe Perches joe at perches.com
Mon Nov 21 20:24:17 EST 2011


On Mon, 2011-11-21 at 16:26 -0200, Fabio Estevam wrote:
> WARNING: line over 80 characters

Trivia...

> #70: FILE: arm/mach-imx/cpu-imx5.c:70:
> +	if (mx51_revision() < IMX_CHIP_REVISION_3_0 && (elf_hwcap & HWCAP_NEON)) {
[]
> diff --git a/arch/arm/mach-imx/cpu-imx5.c b/arch/arm/mach-imx/cpu-imx5.c
[]
> @@ -67,7 +67,8 @@ static int __init mx51_neon_fixup(void)
>  	if (!cpu_is_mx51())
>  		return 0;
>  
> -	if (mx51_revision() < IMX_CHIP_REVISION_3_0 && (elf_hwcap & HWCAP_NEON)) {
> +	if (mx51_revision() < IMX_CHIP_REVISION_3_0 &&
> +					(elf_hwcap & HWCAP_NEON)) {
>  		elf_hwcap &= ~HWCAP_NEON;
>  		pr_info("Turning off NEON support, detected broken NEON implementation\n");
>  	}

Perhaps more readable as:

	if (elf_hwcap & HWCAP_NEON &&
	    mx51_revision() < IMX_CIP_REVISION_3_0) {
		elf_hwcap &= ~HWCAP_NEON;
		etc...
		




More information about the linux-arm-kernel mailing list