[PATCH] ARM: OMAP: PM: only register TWL with voltage layer when device is present

Kevin Hilman khilman at ti.com
Thu Nov 17 14:20:39 EST 2011


"Premi, Sanjeev" <premi at ti.com> writes:

[...]

>> 
>> If PMIC is not TWL family, then I don't expect any functions in
>> twl_common.c to be called.
>
> This is the reason I wanted to know if the check on ".irq" in the
> patch is sufficient. If any PMIC requires & sets "pmic_i2c_board_info.irq"
> then both omap3_twl_init() and omap4_twl_init() will be called.

Only TWL PMICs should be calling these functions, as they are in code
for TWL PMICs *only*.

If you have a non-TWL PMIC, then you should not be using the omap_pmic_*
functions.

Admittedly, these omap_pmic_* functions should be renamed to be clear
that they are TWL specific.

Kevin



More information about the linux-arm-kernel mailing list