[PATCH 1/3] drivers: base: add support for stmp-style devices

Michał Mirosław mirqus at gmail.com
Wed Nov 16 12:57:21 EST 2011


2011/11/16 Arnd Bergmann <arnd at arndb.de>:
> On Wednesday 16 November 2011, Wolfram Sang wrote:
[...]
>> --- /dev/null
>> +++ b/include/linux/stmp_device.h
>> @@ -0,0 +1,19 @@
>> +#ifndef __STMP_DEVICE_H__
>> +#define __STMP_DEVICE_H__
>> +
>> +#define STMP_SET_ADDR                0x4
>> +#define STMP_CLR_ADDR                0x8
>> +#define STMP_TOG_ADDR                0xc
>
> The register numbers should probably go into the implementation file,
> they are not an interface.

Those are offsets - for every register there are "shadow" registers
that do implicit OR, AND NOT, XOR of that register with value written.
There might be better names for those.

Best Regards,
Michał Mirosław



More information about the linux-arm-kernel mailing list