[PATCH] ARM: restart: davinci: use new restart hook

Russell King - ARM Linux linux at arm.linux.org.uk
Tue Nov 15 11:54:08 EST 2011


On Tue, Nov 15, 2011 at 12:22:55AM +0530, Sekhar Nori wrote:
> Rather than using davinci specifci davinci_soc_info based
> restart hook, use the existing arm_pm_restart pointer
> instead.

Thanks for looking at this.

Although you're using arm_pm_restart directly, I'd much prefer to use
the .restart method in the machine description of at all possible.

One of the problems if initializing arm_pm_restart in various functions
is that unless you're familiar with the order in which these functions
are called, you don't know what's being used.  With the machine
description holding it, it's obvious which platform should be using
what method.

Any chance this patch could be reworked along those lines?

Thanks.



More information about the linux-arm-kernel mailing list