[PATCH v4 2/4] ARM: davinci: psc: fix incorrect offsets

Sergei Shtylyov sshtylyov at mvista.com
Tue Nov 15 07:18:45 EST 2011


Hello.

On 15-11-2011 0:12, Sekhar Nori wrote:

> From: Murali Karicheri<m-karicheri2 at ti.com>

> Seperate PDSTAT and PDCTL registers are defined for
> domain 0 and domain 1 where as the code always reads
> the domain 0 PDSTAT register and domain 1 PDCTL register.

> Fix this issue. While at it, introduce usage of macros
> for register masks to improve readability.

> Reviewed-by: Sergei Shtylyov<sshtylyov at mvista.com>
> Signed-off-by: Murali Karicheri<m-karicheri2 at ti.com>
> Signed-off-by: Sekhar Nori<nsekhar at ti.com>
> ---
>   arch/arm/mach-davinci/include/mach/psc.h |    4 +++-
>   arch/arm/mach-davinci/psc.c              |   16 ++++++++--------
>   2 files changed, 11 insertions(+), 9 deletions(-)

> diff --git a/arch/arm/mach-davinci/include/mach/psc.h b/arch/arm/mach-davinci/include/mach/psc.h
> index 8bf279a..8bc3fc2 100644
> --- a/arch/arm/mach-davinci/include/mach/psc.h
> +++ b/arch/arm/mach-davinci/include/mach/psc.h
[...]
> @@ -246,6 +246,8 @@
>   #define MDSTAT_STATE_MASK	0x3f
>   #define PDSTAT_STATE_MASK	0x1f
>   #define MDCTL_FORCE		BIT(31)
> +#define PDCTL_NEXT		BIT(1)

    BIT(0) actually.

WBR, Sergei



More information about the linux-arm-kernel mailing list