[PATCH 1/4] ARM: PL330: Don't call the callbacks if there isn't any active transfer

Jassi Brar jaswinder.singh at linaro.org
Tue Nov 15 02:51:07 EST 2011


On 2 November 2011 20:00, Javi Merino <javi.merino at arm.com> wrote:
> If there are no transactions running it is not only wrong but
> potentially dangerous to call the callbacks.
>
The idea was to have dmac drivers not touch the xfer after it has been submitted
and before the callback is made upon successful transmission or abort/flush.

> There can be a stale struct pl330_req pointer from a previous run, but the
> memory may be free already.
>
Sorry I am unable to fathom the scenario. The pl330_request_channel resets
both pl330_req pointers. Maybe some real failure you saw, could help
me understand.
Thnx.



More information about the linux-arm-kernel mailing list