[PATCH] at91: at91-ohci: fix set/get power

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Nov 14 19:59:33 EST 2011


On 22:39 Mon 14 Nov     , Andrew Victor wrote:
> hi,
> 
> > in commit aa6e52a35 we introduce the support of overcurrent notification
> > but the set and get of the power without checking if the gpio is valid or not
> 
> > +       if (pdata->vbus_pin[port] <= 0)
> > +               return;
> 
> Shouldn't that rather be:
>    if (!gpio_is_valid(pdata->vbus_pin[port]))
>           return;
Yes should be but 0 is not a valid gpio on at91

I've a patch serie to fix the gpio support for at91 so we can use
gpio_is_valid for 3.3

Best Regards,
J.



More information about the linux-arm-kernel mailing list