[PATCH] at91: at91-ohci: fix set/get power

Andrew Victor avictor.za at gmail.com
Mon Nov 14 15:39:21 EST 2011


hi,

> in commit aa6e52a35 we introduce the support of overcurrent notification
> but the set and get of the power without checking if the gpio is valid or not

> +       if (pdata->vbus_pin[port] <= 0)
> +               return;

Shouldn't that rather be:
   if (!gpio_is_valid(pdata->vbus_pin[port]))
          return;


Regards,
  Andrew Victor



More information about the linux-arm-kernel mailing list