[PATCH 1/2] ARM: mx28evk: remove flexcan_pdata __initconst attribute

Dong Aisheng-B29396 B29396 at freescale.com
Fri Nov 11 10:36:13 EST 2011


> -----Original Message-----
> From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> Sent: Friday, November 11, 2011 11:33 PM
> To: Dong Aisheng-B29396
> Cc: Uwe Kleine-König; Guo Shawn-R65073; s.hauer at pengutronix.de;
> kernel at pengutronix.de; linux-arm-kernel at lists.infradead.org;
> w.sang at pengutronix.de
> Subject: Re: [PATCH 1/2] ARM: mx28evk: remove flexcan_pdata __initconst
> attribute
> 
> On Fri, Nov 11, 2011 at 03:30:04PM +0000, Dong Aisheng-B29396 wrote:
> > > -----Original Message-----
> > > From: Russell King - ARM Linux [mailto:linux at arm.linux.org.uk]
> > > Sent: Friday, November 11, 2011 11:28 PM
> > > To: Dong Aisheng-B29396
> > > Cc: Uwe Kleine-König; Guo Shawn-R65073; s.hauer at pengutronix.de;
> > > kernel at pengutronix.de; linux-arm-kernel at lists.infradead.org;
> > > w.sang at pengutronix.de
> > > Subject: Re: [PATCH 1/2] ARM: mx28evk: remove flexcan_pdata
> > > __initconst attribute
> > >
> > > On Fri, Nov 11, 2011 at 03:25:01PM +0000, Dong Aisheng-B29396 wrote:
> > > > -static struct fec_platform_data tx28_fec0_data = {
> > > > +static struct fec_platform_data __initconst tx28_fec0_data = {
> > >
> > > No.  It's spelt:
> > >
> > > static const struct fec_platform_data tx28_fec0_data __initconst = {
> > Thanks for reminder, I missed the first const. :-)
> 
> That's not the only thing.  Note the placement of the __initconst too.

Got it, thanks for your carefully review. :-)

Regards
Dong Aisheng




More information about the linux-arm-kernel mailing list