[PATCH v4] ARM/mx35/3ds: gpio: add mc9s08dz60 gpio function

Wu Guoxing-B39297 B39297 at freescale.com
Thu Nov 10 06:38:36 EST 2011


Hi Wolfram & Marc:
  I sent out the v6 patch to remove this from both probe and remove functions
Also, in remove function, changed to return the error code.

  Please review the V6 patch.

  Thanks for the comments!

Best Regards
Wu Guoxing

-----Original Message-----
From: Wolfram Sang [mailto:w.sang at pengutronix.de] 
Sent: Thursday, November 10, 2011 7:09 PM
To: Wu Guoxing-B39297
Cc: Marc Kleine-Budde; grant.likely at secretlab.ca; s.hauer at pengutronix.de; shawn.guo at linaro.org; linux-arm-kernel at lists.infradead.org
Subject: Re: [PATCH v4] ARM/mx35/3ds: gpio: add mc9s08dz60 gpio function

>   I changed the code to unset i2c client data just when 
> gipochip_remove successes, Otherwise, there will be problems next time the remove function is called.

The i2c-core will do it on probe-failure and on remove. Check e4a7b9b0.

Thanks,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |




More information about the linux-arm-kernel mailing list