[PATCH 1/2] ARM: EXYNOS4: convert MCT to percpu interrupt API

[MyungJoo Ham]

On Thu, Nov 3, 2011 at 2:30 AM, Marc Zyngier <marc.zyngier at arm.com> wrote:
> MCT recently gained per cpu interrupts, and missed the fact that
> ARM has moved to a genirq based implementation.
>
> This patch converts the driver to the new API.
>
> Boot tested on Origen.
>
> Cc: Kukjin Kim <kgene.kim at samsung.com>
> Signed-off-by: Marc Zyngier <marc.zyngier at arm.com>

There is one concern regarding the CONFIG_LOCAL_TIMER.

[]
>  #endif /* CONFIG_LOCAL_TIMERS */
>
>  static void __init exynos4_timer_resources(void)
> @@ -438,6 +442,16 @@ static void __init exynos4_timer_resources(void)
>        mct_clk = clk_get(NULL, "xtal");
>
>        clk_rate = clk_get_rate(mct_clk);
> +
> +       if (mct_int_type == MCT_INT_PPI) {
> +               int err;
> +
> +               err = request_percpu_irq(IRQ_MCT_LOCALTIMER,
> +                                        exynos4_mct_tick_isr, "MCT",
> +                                        &percpu_mct_tick);
> +               WARN(err, "MCT: can't request IRQ %d (%d)\n",
> +                    IRQ_MCT_LOCALTIMER, err);
> +       }
>  }
>

You've added exynos4_mct_tick_isr, which is defined in
CONFIG_LOCAL_TIMER section, in the place that is compiled without
CONFIG_LOCAL_TIMER.
I guess we are going to stop supporting LOCAL_TIMER in Exynos later
and this could be a problem with it.


Cheers!
MyungJoo

-- 
MyungJoo Ham, Ph.D.
Mobile Software Platform Lab, DMC Business, Samsung Electronics