[PATCH 2/2] ARM: highbank: convert logical CPU numbers to physical numbers

Will Deacon will.deacon at arm.com
Tue Nov 8 11:10:00 EST 2011


Hi Rob,

On Tue, Nov 08, 2011 at 03:59:17PM +0000, Rob Herring wrote:
> On 11/08/2011 08:34 AM, Will Deacon wrote:
> > This patch uses the new cpu_logical_map() macro for converting logical
> > CPU numbers into physical numbers when releasing CPUs during the SMP
> > boot and CPU hotplug paths.
> > 
> > Cc: Rob Herring <rob.herring at calxeda.com>
> > Signed-off-by: Will Deacon <will.deacon at arm.com>
> > ---
> >  arch/arm/mach-highbank/highbank.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c
> > index b82dcf0..a6cdc27 100644
> > --- a/arch/arm/mach-highbank/highbank.c
> > +++ b/arch/arm/mach-highbank/highbank.c
> > @@ -22,6 +22,7 @@
> >  #include <linux/of_irq.h>
> >  #include <linux/of_platform.h>
> >  #include <linux/of_address.h>
> > +#include <linux/smp.h>
> >  
> >  #include <asm/cacheflush.h>
> >  #include <asm/unified.h>
> > @@ -72,6 +73,7 @@ static void __init highbank_map_io(void)
> >  
> >  void highbank_set_cpu_jump(int cpu, void *jump_addr)
> >  {
> > +	cpu = cpu_logical_map(cpu);
> 
> This doesn't build for !CONFIG_SMP. It's possible to want to do this for
> core 0 in the cpuidle case.

Damn, I suspect I have the same problem with the imx code. Although it would
be nice to fix this inside of cpu_logical_map, I can't see a way to do that
without moving it into a different header file (which?), so I think the best
option is to ifdef at the point of use.

I'll throw a v2 your way this week.

Will



More information about the linux-arm-kernel mailing list