[PATCH v6 01/11] ARM: mmp: fix build error on gpio

Haojian Zhuang haojian.zhuang at gmail.com
Tue Nov 8 08:09:56 EST 2011


On Tue, Nov 8, 2011 at 7:19 PM, Jason Liu <liu.h.jason at gmail.com> wrote:
> 2011/11/8 Haojian Zhuang <haojian.zhuang at marvell.com>:
>> Parameters of GPIO_REG() should be assigned as volatile.
>>
>> arch/arm/plat-pxa/include/plat/gpio.h: In function ‘gpio_get_value’:
>> arch/arm/plat-pxa/include/plat/gpio.h:12:21: error: invalid operands to
>> binary & (have ‘void *’ and ‘int’)
>> arch/arm/plat-pxa/include/plat/gpio.h: In function ‘gpio_set_value’:
>> arch/arm/plat-pxa/include/plat/gpio.h:21:4: error: lvalue required as
>> left operand of assignment
>> arch/arm/plat-pxa/include/plat/gpio.h:23:4: error: lvalue required as
>> left operand of assignment
>>
>> Signed-off-by: Haojian Zhuang <haojian.zhuang at marvell.com>
>> ---
>>  arch/arm/mach-mmp/include/mach/gpio-pxa.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>
> It seems that this is pxa related fix, why not have pxa keyword in the
> commit log
> which will make the patch filter life easier.
>
> Jason Liu
>

Because this issue is caused by incorrect macro definition in arch-mmp.
Both arch-pxa and arch-mmp is sharing plat-pxa.



More information about the linux-arm-kernel mailing list