[PATCH 3/3 v3.1] ARM: S3C64XX: Correct reservation of GPIOs for CPU module on Cragganmore
kgene.kim at samsung.com
Fri Nov 4 01:02:16 EDT 2011
Mark Brown wrote:
> On Thu, Nov 03, 2011 at 04:45:21PM +0900, Kukjin Kim wrote:
> > Mark Brown wrote:
> > > #define PCA935X_GPIO_BASE GPIO_BOARD_START
> > > #define CODEC_GPIO_BASE (GPIO_BOARD_START + 8)
> > > #define GLENFARCLAS_PMIC_GPIO_BASE (GPIO_BOARD_START + 16)
> > > +#define BANFF_PMIC_GPIO_BASE
> > > (GLENFARCLAS_PMIC_GPIO_BASE + 16)
> > Above definitions are at mach/crag6410.h file not mach-crag6410.c file
> > tree.
> > And in my opinion, to use GPIO_BOARD_START is better than to use
> > GLENFARCLAS_PMIC_GPIO_BASE like others for easily reading.
> I'd prefer it if the were all defined in terms of the preceeding one but
> > So I think, this should be following...?
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
More information about the linux-arm-kernel