[PATCH 1/2 v4] atmel/spi: fix missing probe
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Nov 3 18:47:56 EDT 2011
On Fri, Nov 04, 2011 at 01:57:40AM +0800, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Commit 940ab889 "drivercore: Add helper macro for platform_driver boilerplate"
> converted this driver to use module_platform_driver, but due to the use
> of platform_driver_probe(), this resulted in the call to atmel_spi_probe being
> lost. Place the call to this function into the driver structure.
Let me say again, this should not be the first patch in the series.
If you're trying to fix a bug don't introduce a new bug by fixing
If you did this with, say, the VM or FS subsystem, you'll have this
Moreover, it's bad practice to do "fixes" in this way, especially when
it's trivial to do it _right_ as I've already mentioned several times.
I still maintain that it should be _one_ patch fixing these issues, not
More information about the linux-arm-kernel