[PATCH v2] atmel/spi: fix missing probe during the switch to module_platform_driver
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Nov 3 14:08:21 EDT 2011
On Thu, Nov 03, 2011 at 07:03:38PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:43 Thu 03 Nov , Russell King - ARM Linux wrote:
> > On Thu, Nov 03, 2011 at 05:51:13PM +0100, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > this is an other fix I do not want to fix 2 issue in one commit and I do care
> > > of mismatch erros I fix them all the time I send patch for some rm9200 few
> > > weeks ago
> > It should not be a separate patch - it's all to do with fixing the
> > original problem.
> yes when we was supposed to swtch to module_platform_driver we use the .probe
> which is suposed to be __devinit in this case but I was prefering to do it in
> 2 steps
Then do the __devinit transformation _first_ so you don't introduce a new
bug in the middle of your 'fix'.
But I personally think you're just creating needless churn by splitting
this one logical change.
More information about the linux-arm-kernel