[PATCH v2 2/8] arm/tegra: prepare early init for multiple tegra variants
Russell King - ARM Linux
linux at arm.linux.org.uk
Thu Nov 3 06:02:35 EDT 2011
On Thu, Nov 03, 2011 at 11:21:16AM +0200, Peter De Schrijver wrote:
> On Wed, Nov 02, 2011 at 07:30:43PM +0100, Colin Cross wrote:
> > On Wed, Nov 2, 2011 at 7:09 AM, Peter De Schrijver
> > <pdeschrijver at nvidia.com> wrote:
> > > This patch splits the early init code in a common and a tegra20 specific part.
> > > L2 cache initialization is generalized and discovers the cache associativity
> > > at runtime.
> > >
> > > Signed-off-by: Peter De Schrijver <pdeschrijver at nvidia.com>
> > > ---
> > <snip>
> >
> > > -static __initdata struct tegra_clk_init_table common_clk_init_table[] = {
> > > +void (*arch_reset)(char mode, const char *cmd) = tegra_assert_system_reset;
> > > +
> > This is unrelated to the patch description?
> >
>
> This is a left over from the past. Will be removed from the next version.
Please can Tegra move over to hooking the restart via arm_pm_restart()
rather than via arch_reset()? That would leave arch_reset() for
software-based reboot methods - which I suspect Tegra doesn't use.
That would allow Tegra to dovetail into the arch_reset cleanup work much
better than it would otherwise do.
More information about the linux-arm-kernel
mailing list