[PATCH V6] SDHCI: S3C: Use generic clock names for sdhci bus clock options

Kukjin Kim kgene.kim at samsung.com
Wed Nov 2 08:12:49 EDT 2011


Rajeshwari Shinde wrote:
> 
> This patch modifies the driver to stop depending on the clock names
> being passed from the platform and switch over to bus clock lookup
> using generic clock names.
> 
> V6 Changes:
> Changed sprintf to snprintf as suggested by Chris Ball.
> 
> Signed-off-by: Rajeshwari Shinde <rajeshwari.s at samsung.com>

Acked-by: Kukjin Kim <kgene.kim at samsung.com>

Hi Chirs,

Could you please pick this up in your tree for this merge window?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

> ---
>  drivers/mmc/host/sdhci-s3c.c |    7 ++-----
>  1 files changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci-s3c.c b/drivers/mmc/host/sdhci-s3c.c
> index 82709b6..488223c 100644
> --- a/drivers/mmc/host/sdhci-s3c.c
> +++ b/drivers/mmc/host/sdhci-s3c.c
> @@ -435,14 +435,11 @@ static int __devinit sdhci_s3c_probe(struct
> platform_device *pdev)
> 
>  	for (clks = 0, ptr = 0; ptr < MAX_BUS_CLK; ptr++) {
>  		struct clk *clk;
> -		char *name = pdata->clocks[ptr];
> -
> -		if (name == NULL)
> -			continue;
> +		char name[14];
> 
> +		snprintf(name, 14, "mmc_busclk.%d", ptr);
>  		clk = clk_get(dev, name);
>  		if (IS_ERR(clk)) {
> -			dev_err(dev, "failed to get clock %s\n", name);
>  			continue;
>  		}
> 
> --
> 1.7.4.4




More information about the linux-arm-kernel mailing list