[PATCH 5/9] at91: use structure to store the current soc

[Andrew Victor]

hi,

>> You are missing the point. You have a function called soc_detect which
>> returns void. It modifies a structure called at91_soc_data (this is not
>> obvious from looking just at the function declaration) and returns
> no sorry it's very clear

Even better would be:
    struct at91_soc* at91_soc_detect();

It returns NULL if the AT91 is not detected or not supported in the
kernel image.


> at91 for the arch
> soc_data data related to the soc
>
> you can see 1000 times of time in the kernel
> gic_data
> cpu_data etc....

If it's a shared with other ARM processors (ie, OMAP, PXA, etc), then soc_data.
If it's only used on AT91 processors, then it gets prefixed with at91_.


Regards,
  Andrew Victor