[PATCH V4 3/5] dmaengine/dw_dmac: Divide one sg to many desc, if sg len is greater than DWC_MAX_COUNT
viresh kumar
viresh.kumar at st.com
Mon May 9 02:03:21 EDT 2011
On 05/09/2011 10:50 AM, Koul, Vinod wrote:
>> > @@ -695,9 +695,15 @@ dwc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
>> > reg = dws->tx_reg;
>> > for_each_sg(sgl, sg, sg_len, i) {
>> > struct dw_desc *desc;
>> > - u32 len;
>> > - u32 mem;
>> > + u32 len, dlen, mem;
>> >
>> > + mem = sg_phys(sg);
>> > + len = sg_dma_len(sg);
>> > + mem_width = 2;
> hardcoding mem_width doesn't make sense, you should take this from input
> params
Firstly, this change is not introduced in this patch, i have just rearranged this.
So, will send separate patch if this change is required.
Secondly, peripheral width is taken from chan->private. And by 2 for mem_width,
we meant word-by-word here. Shouldn't we always try word-by-word here?
How should we pass width for memory?
--
viresh
More information about the linux-arm-kernel
mailing list