[PATCH] pxa: Fix PGSR register address calculation

Eric Miao eric.y.miao at gmail.com
Sun May 8 23:48:57 EDT 2011


On Sun, May 8, 2011 at 9:54 AM, Paul Parsons <lost.distance at yahoo.com> wrote:
> The file mfp-pxa2xx.c defines a macro, PGSR(), which translates a gpio bank number to a PGSR register address. The function pxa2xx_mfp_suspend() erroneously passed in a gpio number instead of a gpio bank number.
>
> Signed-off-by: Paul Parsons <lost.distance at yahoo.com>

Applied to 'fix'.

> ---
> --- clean-2.6.39-rc6/arch/arm/mach-pxa/mfp-pxa2xx.c     2011-03-15 01:20:32.000000000 +0000
> +++ linux-2.6.39-rc6/arch/arm/mach-pxa/mfp-pxa2xx.c     2011-05-08 02:09:36.706294235 +0100
> @@ -347,9 +347,9 @@ static int pxa2xx_mfp_suspend(struct sys
>                if ((gpio_desc[i].config & MFP_LPM_KEEP_OUTPUT) &&
>                    (GPDR(i) & GPIO_bit(i))) {
>                        if (GPLR(i) & GPIO_bit(i))
> -                               PGSR(i) |= GPIO_bit(i);
> +                               PGSR(gpio_to_bank(i)) |= GPIO_bit(i);
>                        else
> -                               PGSR(i) &= ~GPIO_bit(i);
> +                               PGSR(gpio_to_bank(i)) &= ~GPIO_bit(i);
>                }
>        }
>
>
>


More information about the linux-arm-kernel mailing list