[PATCH][WAS:bcmai, axi] bcma: add Broadcom specific AMBA bus driver

Hauke Mehrtens hauke at hauke-m.de
Sun May 8 08:48:15 EDT 2011


On 05/05/2011 11:59 PM, Rafał Miłecki wrote:
.....
> --- /dev/null
> +++ b/drivers/bcma/bcma_private.h
.....
> +
> +#define BCMA_ADDR_BASE		0x18000000
> +#define BCMA_WRAP_BASE		0x18100000
> +
......
> --- /dev/null
> +++ b/drivers/bcma/scan.h
> @@ -0,0 +1,56 @@
> +#ifndef BCMA_SCAN_H_
> +#define BCMA_SCAN_H_
> +
> +#define BCMA_ADDR_BASE		0x18000000
> +#define BCMA_WRAP_BASE		0x18100000
> +
.....

While graping through the code I found this. BCMA_ADDR_BASE and
BCMA_WRAP_BASE are defined twice.

Why are some constants defined in purpose specific headers in
drivers/bcma/*.h like drivers/bcma/scan.h and some in
drivers/bcma/bcma_private.h and other in include/linux/bcma/bcma_regs.h ?

Hauke



More information about the linux-arm-kernel mailing list