[PATCH] [RFC] USB: fsl_udc_core: fix build-failure for ARM
Russell King - ARM Linux
linux at arm.linux.org.uk
Fri May 6 14:47:47 EDT 2011
On Fri, May 06, 2011 at 12:03:10PM +0200, Uwe Kleine-König wrote:
> Hi Russell,
> On Fri, May 06, 2011 at 10:04:49AM +0100, Russell King - ARM Linux wrote:
> > On Fri, May 06, 2011 at 11:00:05AM +0200, Uwe Kleine-König wrote:
> > > I'm unsure about getting rid of the flush_dcache_range. If powerpc needs
> > > a flush ARM probably does, too, no?
> > > If so, what it the right thing to do? Implement flush_dcache_range for
> > > ARM (just wrapping flush_dcache_page?)?
> > On ARM, we assume all new pages have dirty dcache, which allows us to
> > neatly end the ever-increasing quantity of drivers which need to be
> > patched to work on ARM. PowerPC doesn't do this.
> Unless I'm missing something the cache flushed here isn't necessarily
> for a new page. (And even if the flush isn't needed here for ARM, not
> having flush_dcache_range results in #ifdefs for each user of it. So a
> definition would be nice, wouldn't it?)
Well, the folk introducing it should have added it to cachetlb.txt so
that other folk know what the intentions of it are. At the moment it
seems to be an unofficial extension with unknown semantics. Maybe the
PPC folk can clear it up and fix other arches if they wish to make it
an official arch cachetlb extension.
More information about the linux-arm-kernel