[PATCH V2 01/16] mmc: omap_hsmmc: fix missing mmc_release_host() in no_off case
Adrian Hunter
adrian.hunter at nokia.com
Fri May 6 05:14:00 EDT 2011
From: Sudhir Bera <ext-sudhir.bera at nokia.com>
In fact the no_off check here will not be hit because
'omap_hsmmc_disabled_to_sleep()' won't schedule a
deeper disable in the no_off case.
Signed-off-by: Sudhir Bera <ext-sudhir.bera at nokia.com>
Signed-off-by: Adrian Hunter <adrian.hunter at nokia.com>
---
drivers/mmc/host/omap_hsmmc.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 259ece0..73faaec 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1770,15 +1770,13 @@ static int omap_hsmmc_sleep_to_off(struct omap_hsmmc_host *host)
return 0;
if (mmc_slot(host).no_off)
- return 0;
+ goto out;
if (!((host->mmc->caps & MMC_CAP_NONREMOVABLE) ||
mmc_slot(host).card_detect ||
(mmc_slot(host).get_cover_state &&
- mmc_slot(host).get_cover_state(host->dev, host->slot_id)))) {
- mmc_release_host(host->mmc);
- return 0;
- }
+ mmc_slot(host).get_cover_state(host->dev, host->slot_id))))
+ goto out;
mmc_slot(host).set_power(host->dev, host->slot_id, 0, 0);
host->vdd = 0;
@@ -1788,7 +1786,7 @@ static int omap_hsmmc_sleep_to_off(struct omap_hsmmc_host *host)
host->dpm_state == CARDSLEEP ? "CARDSLEEP" : "REGSLEEP");
host->dpm_state = OFF;
-
+out:
mmc_release_host(host->mmc);
return 0;
--
1.7.0.4
More information about the linux-arm-kernel
mailing list