[PATCH 1/5] OMAP3 cpuidle: remove useless SDP specific timings

Kevin Hilman khilman at ti.com
Wed May 4 10:40:01 EDT 2011


jean.pihet at newoldbits.com writes:

> From: Jean Pihet <j-pihet at ti.com>
>
> The cpuidle states settings can be overriden by some board-
> specific settings, by calling omap3_pm_init_cpuidle.
> Remove the 3430SDP specific states settings registration
> since the figures are identical to the default ones (in cpuidle34xx.c).
>
> Signed-off-by: Jean Pihet <j-pihet at ti.com>

Thanks,  queuing for 2.6.40 (branch: for_2.6.40/pm-cleanup)

Kevin

> ---
>  arch/arm/mach-omap2/board-3430sdp.c |   19 -------------------
>  1 files changed, 0 insertions(+), 19 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-3430sdp.c b/arch/arm/mach-omap2/board-3430sdp.c
> index 9afd087..7ffad7b 100644
> --- a/arch/arm/mach-omap2/board-3430sdp.c
> +++ b/arch/arm/mach-omap2/board-3430sdp.c
> @@ -59,24 +59,6 @@
>  
>  #define TWL4030_MSECURE_GPIO 22
>  
> -/* FIXME: These values need to be updated based on more profiling on 3430sdp*/
> -static struct cpuidle_params omap3_cpuidle_params_table[] = {
> -	/* C1 */
> -	{1, 2, 2, 5},
> -	/* C2 */
> -	{1, 10, 10, 30},
> -	/* C3 */
> -	{1, 50, 50, 300},
> -	/* C4 */
> -	{1, 1500, 1800, 4000},
> -	/* C5 */
> -	{1, 2500, 7500, 12000},
> -	/* C6 */
> -	{1, 3000, 8500, 15000},
> -	/* C7 */
> -	{1, 10000, 30000, 300000},
> -};
> -
>  static uint32_t board_keymap[] = {
>  	KEY(0, 0, KEY_LEFT),
>  	KEY(0, 1, KEY_RIGHT),
> @@ -883,7 +865,6 @@ static void __init omap_3430sdp_init(void)
>  	omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
>  	omap_board_config = sdp3430_config;
>  	omap_board_config_size = ARRAY_SIZE(sdp3430_config);
> -	omap3_pm_init_cpuidle(omap3_cpuidle_params_table);
>  	omap3430_i2c_init();
>  	omap_display_init(&sdp3430_dss_data);
>  	if (omap_rev() > OMAP3430_REV_ES1_0)



More information about the linux-arm-kernel mailing list