[PATCH v2 05/12] OMAP: Serial: Hold console lock for console usage.

Russell King - ARM Linux linux at arm.linux.org.uk
Wed May 4 06:09:14 EDT 2011


On Wed, May 04, 2011 at 03:02:33AM -0700, Tony Lindgren wrote:
> * Govindraj.R <govindraj.raja at ti.com> [110429 05:39]:
> >
> > Also during bootup console_lock is not available.
> >        --> uart_add_one_port
> > 	   --> console_register
> > 	       --> console_lock
> > 	        --> console_unlock
> > 	             --> call_console_drivers (here yet console_lock is not released)
> > 		          --> uart_console_write
> > 
> > Hence convert prints from omap_device_enable/disable to pr_debug.
> 
> This sounds like a hack considering we have things working with
> pr_debug currently.

It also highlights a different problem: stuffing subsystems full of
debug, and keeping it way after the subsystem has been brought to a
working state not only adds code bloat but also can cause additional
bugs.



More information about the linux-arm-kernel mailing list