[PATCH 4/4] omap: musb: introduce default baord config

Tony Lindgren tony at atomide.com
Tue May 3 03:50:13 EDT 2011


* Felipe Balbi <balbi at ti.com> [110502 07:22]:
> On Mon, May 02, 2011 at 07:20:52AM -0700, Tony Lindgren wrote:
> > * Oleg Drokin <green at linuxhacker.ru> [110428 09:33]:
> > > 
> > > So to me it looks like something totally in realm of musb driver itself.
> > > Nothing bad happens if you configure your MUSB as say OTG while in fact only
> > > peripheral mode was implemented, it continues to work as it did.
> > > Of course enabling HOST mode may not magically make things work, but
> > > I suspect this could be addressed from Kconfig itself instead.

So based on the discussion it sounds like we still the board specific
configuration for the mode in some cases.

> > I think Felipe already has some patches to remove the various Kconfig
> > options for musb?  In any case, the musb configuration should be a
> > runtime configuration passed in the platform data or cmdline.
> 
> Yeah, I'm planning to get rid of all the ifdeferry and always compile it
> with HOST and Peripheral support. It's only few extra tens of bytes
> anyway. Still, I doubt I can get that done for this merge window, I
> already have pending the debugging rework.

So care to ack the original patch then? It still allows overriding
the default mode from board-*.c file as needed.

Regards,

Tony



More information about the linux-arm-kernel mailing list