[PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100

Kukjin Kim kgene.kim at samsung.com
Sun May 1 21:09:55 EDT 2011


Russell King - ARM Linux wrote:
> 
> On Mon, Apr 04, 2011 at 08:47:17PM +0900, Kukjin Kim wrote:
> > Russell King - ARM Linux wrote:
> > >
> > > On Sat, Apr 02, 2011 at 11:09:15AM +0900, Kukjin Kim wrote:
> > > > The current mainline codes of ARCH_S5PC100 can not support
> > > > suspend to ram. So needs this for preventing build error.
> > > >
> > > > Cc: Russell King <rmk+kernel at arm.linux.org.uk>
> > > > Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
> > > > ---
> > > > Oops, I missed this in my previous patch.
> > > >
> > > > As I know, firstly ARCH_S5P64X0 will support suspend to ram
> > > > then ARCH_S5PC100 will do it. But right now, we need this.
> > >
> > > I'd much rather do this a different way - let me know if this means
> > > the SoC based dependencies can be dropped.  Patches to follow.
> >
> > Yeah, I checked your patches. It's ok to me but this is also needed
right
> > now for preventing build errors with s5pc100_defconfig...because there
is
> no
> > regarding headers for supporting suspend to ram.
> >
> > However as I mentioned, the suspend to ram will be supported soon on
them
> > then we can drop its dependencies.
> 
> Could I have an updated patch which applies to mainline please?

From: Kukjin Kim <kgene.kim at samsung.com>
Date: Mon, 2 May 2011 09:33:01 +0900
Subject: [PATCH] ARM: Suspend: Fix build error on ARCH_S5PC100

The current mainline codes of ARCH_S5PC100 cannot support
suspend to ram. So needs this for preventing build error.

Cc: Russell King <rmk+kernel at arm.linux.org.uk>
Signed-off-by: Kukjin Kim <kgene.kim at samsung.com>
---
 arch/arm/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 377a7a5..96839d9 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -2010,7 +2010,7 @@ menu "Power management options"
 source "kernel/power/Kconfig"

 config ARCH_SUSPEND_POSSIBLE
-	depends on !ARCH_S5P64X0 && !ARCH_S5P6442
+	depends on !ARCH_S5P64X0 && !ARCH_S5P6442 && !ARCH_S5PC100
 	depends on CPU_ARM920T || CPU_ARM926T || CPU_SA1100 || \
 		CPU_V6 || CPU_V6K || CPU_V7 || CPU_XSC3 || CPU_XSCALE
 	def_bool y
-- 

If any problems, please let me know.
Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list