[PATCH 3/7] ARM: SAMSUNG: Add SPI clock definitions for SAMSUNG SoCs

padma venkat padma.kvr at gmail.com
Thu Jun 30 23:31:24 EDT 2011


Hi Russell,Jassi

On Thu, Jun 30, 2011 at 3:13 PM, Jassi Brar <jassisinghbrar at gmail.com> wrote:
> On Thu, Jun 30, 2011 at 3:00 PM, Russell King - ARM Linux
> <linux at arm.linux.org.uk> wrote:
>> On Thu, Jun 30, 2011 at 08:25:19AM -0400, Padmavathi Venna wrote:
>>> SPI Clocks were defined in dev-spi.c of machine specific folder.
>>> To make SPI devices common across all SoCs,dev-spi.c is moved
>>> from machine specific folder to plat-samsung. So SPI clock
>>> definitions has been moved from dev-spi.c to SoC specific machine
>>> folder for S3C64XX,S5P64X0,S5PC100 and S5PV210
>>
>> This just shows how sick the Samsung code is by abusing the clk API.
>> If it stopped that abuse and switched over to clkdev none of this would
>> be necessary.
> I am anyways not for the patch set.
> Though this 'sickness' predates clkdev, and I agree it should be changed now.

I will prepare new set of patches based on clkdev code and send for review.

Thanks&Regards
Padma

> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



More information about the linux-arm-kernel mailing list