[PATCH] omap: cleanup NAND platform data
Tony Lindgren
tony at atomide.com
Wed Jun 29 04:12:43 EDT 2011
* Grazvydas Ignotas <notasas at gmail.com> [110603 15:01]:
> On Sat, Jun 4, 2011 at 12:14 AM, Vimal Singh <vimal.newwork at gmail.com> wrote:
> > On Sat, Jun 4, 2011 at 1:26 AM, Grazvydas Ignotas <notasas at gmail.com> wrote:
> >>
> >> -static int omap2_nand_gpmc_retime(void)
> >> +static int omap2_nand_gpmc_retime(struct omap_nand_platform_data *gpmc_nand_data)
> >> {
> >> struct gpmc_timings t;
> >> int err;
> >> @@ -83,13 +81,11 @@ static int omap2_nand_gpmc_retime(void)
> >> return 0;
> >> }
> >>
> >> -int __init gpmc_nand_init(struct omap_nand_platform_data *_nand_data)
> >> +int __init gpmc_nand_init(struct omap_nand_platform_data *gpmc_nand_data)
> >> {
> >> int err = 0;
> >> struct device *dev = &gpmc_nand_device.dev;
> >>
> >> - gpmc_nand_data = _nand_data;
> >> - gpmc_nand_data->nand_setup = omap2_nand_gpmc_retime;
> >
> > Purpose of doing this was to be able to utilise
> > 'omap2_nand_gpmc_retime', when DVFS is ready to use it,
> > for changing timing parameter dynamically when a frequency change is done.
>
> Well but it seems currently ...retime() only does single static
> configuration, I guess when it's updated to do DVFS stuff callback can
> easily be added back..
Applying this into devel-cleanup.
Regards,
Tony
More information about the linux-arm-kernel
mailing list