[PATCH 06/10] omap2+: Remove gptimer_wakeup for now

Kevin Hilman khilman at ti.com
Mon Jun 27 17:16:02 EDT 2011


Tony Lindgren <tony at atomide.com> writes:

> * Kevin Hilman <khilman at ti.com> [110627 10:27]:
>> Tony Lindgren <tony at atomide.com> writes:
>> 
>> > This removes the support for setting the wake-up timer for debugging.
>> >
>> > Later on we can reserve gptimer1 for PM code only and have similar
>> > functionality.
>> >
>> > Signed-off-by: Tony Lindgren <tony at atomide.com>
>> > Reviewed-by: Kevin Hilman <khilman at ti.com>
>> 
>> Another minor change to fold into patch: gptimer_wakeup doesn't exist
>> anymore, so should probably be removed from dmtimer.h
>
> Thanks, updated patch below. Still with your Reviewed-by

Thanks.

> despite causing you more work with the removal of the
> interface :)

Well, part of me wants to keep it because I use it all the time, but I
know it's an ugly hack so I won't fight for it.  Also the timer cleanups
are nice and more important.  So for now I'll just keep a patch in the
PM branch for the wakeup timer.

I'm talking with tglx offline if we can make a generic interface for
this in the clockevents layer.  The clockevents already have a
notification on suspend that we could use for this.

Kevin



More information about the linux-arm-kernel mailing list