[PATCH 08/10] omap2+: Use dmtimer macros for clocksource

Kevin Hilman khilman at ti.com
Thu Jun 23 12:47:47 EDT 2011


Kevin Hilman <khilman at ti.com> writes:

> Tony Lindgren <tony at atomide.com> writes:
>
>> Use dmtimer macros for clocksource. As with the clockevent,
>> this allows us to initialize the rest of dmtimer code later on.
>>
>> Note that eventually we will be initializing the timesource
>> from init_early so sched_clock will work properly for
>> CONFIG_PRINTK_TIME.
>>
>> Signed-off-by: Tony Lindgren <tony at atomide.com>
>> Reviewed-by: Kevin Hilman <khilman at ti.com>
>
> [...]
>
>> +/* Setup free-running counter for clocksource */
>> +static void __init omap2_gp_clocksource_init(int gptimer_id,
>> +						const char *fck_source)
>> +{
>> +	int res;
>> +
>> +	res = omap_dm_timer_init_one(&clksrc, gptimer_id, fck_source);
>> +	BUG_ON(res);
>
> This is a change from previous code where the clocksource was requesting
> any timer, not a specific one.   
>
> Also, you're using the same gptimer_id here as the clockevent, which
> means this is guaranteed to fail.

Nevermind, ignore this comment.

I misread the macros.

Sorry for the noise.

Kevin



More information about the linux-arm-kernel mailing list