[PATCH 7/7] ARM: EXYNOS4: Move S5P_CENTRAL_SEQ_CONFIGURATION setting for PM

Kukjin Kim kgene.kim at samsung.com
Thu Jun 23 04:05:39 EDT 2011


Sergei Shtylyov wrote:
> 
> Hello.
> 
Hi :)

> On 22-06-2011 12:46, Kukjin Kim wrote:
> 
> > From: Jaecheol Lee<jc.lee at samsung.com>
> 
> > We need to balance between set and check
> S5P_CENTRAL_SEQ_CONFIGURATION
> > register in syscore_ops suspend/resume function when failure in enter
> > suspend mode. Moved this register setting for PM for the purpose of
balancing.
> 
> > Signed-off-by: Jaecheol Lee<jc.lee at samsung.com>
> > Signed-off-by: Kukjin Kim<kgene.kim at samsung.com>
> > ---
> >   arch/arm/mach-exynos4/pm.c |   22 ++++++++++++++--------
> >   1 files changed, 14 insertions(+), 8 deletions(-)
> 
> > diff --git a/arch/arm/mach-exynos4/pm.c b/arch/arm/mach-exynos4/pm.c
> > index b037fba..a103c13 100644
> > --- a/arch/arm/mach-exynos4/pm.c
> > +++ b/arch/arm/mach-exynos4/pm.c
> [...]
> > @@ -413,6 +405,19 @@ static __init int exynos4_pm_drvinit(void)
> >   }
> >   arch_initcall(exynos4_pm_drvinit);
> >
> > +static int exynos4_pm_suspend(void)
> > +{
> > +	unsigned long tmp;
> > +
> > +	/* Setting Central Sequence Register for power down mode */
> > +
> > +	tmp = __raw_readl(S5P_CENTRAL_SEQ_CONFIGURATION);
> > +	tmp &= ~(S5P_CENTRAL_LOWPWR_CFG);
> 
>     Could drop useless parens, while at it.
> 
Sergei, thanks ;)

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim at samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.




More information about the linux-arm-kernel mailing list