[PATCH] USB: ehci: use packed, aligned(4) instead of removing the packed attribute

Arnd Bergmann arnd at arndb.de
Mon Jun 20 16:07:22 EDT 2011


On Monday 20 June 2011 19:39:34 Alexander Holler wrote:
> That packed without an additional aligned() caused errors on ARM with 
> gcc 4.6 is another problem which got (currently) fixed by removing packed.

Packed caused errors because it is *wrong*. The code as it was used undefined
behavior in the language.

> But this introduces imho doubts and uncertainty about if padding bytes 
> could be between the members, therefore I would prefer to use packed 
> with aligned instead of removing the packed.

Packing was never an issue here, please stop talking about it.

	Arnd



More information about the linux-arm-kernel mailing list